Conversation
Contributor
Author
|
Both |
lbargaoanu
reviewed
Jan 31, 2022
Contributor
Author
|
@lbargaoanu can you review this? I can click the red button but would rather not :) |
lbargaoanu
approved these changes
Feb 11, 2022
Contributor
lbargaoanu
left a comment
lbargaoanu
left a comment
There was a problem hiding this comment.
I still think we need to refactor to a base class, but we can do that anytime.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One step towards allowing xplat/*nix-based development
Fixes #3521