fix: cross-animation state machine transitions#513
Merged
Conversation
When transitioning between animations in the state machine, the marker was being set before the new animation was loaded, causing it to resolve against the old animation's marker data. This reorders state entry to: 1. Clear stale marker before load 2. Load the new animation (with autoplay suppressed) 3. Apply marker against the newly loaded animation data 4. Set playback mode, then autoplay last Also resets current_frame and updated flag in renderer clear() so stale frame state from the previous animation does not carry over.
|
theashraf
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes cross-animation state machine transitions where returning to a previous animation (e.g., Second Scene → Main Scene) would cause the animation to stop rendering.
load_animation()re-applies the saved theme after loading, but themes are animation-specific. Stale slot values from the old animation causedflush_slots()to fail, silently breakingrender()and preventingOnCompletefrom ever firing.