Skip to content

Conversation

@marionbarker
Copy link
Contributor

No description provided.

@marionbarker
Copy link
Contributor Author

I have reviewed the changes.
LoopWorkspace builds with this modification and the other translations branches.

Note - there are a number of translations brought in because they were recently updated by translators. Some of them do not need to be included.

Several weeks ago, I made the choice to delete some existing keys and translations on lokalise (for items like "CFBundleNames" and "NSHumanReadableCopyright"). However, for the next upload to lokalise, those items come back.

The better choice - and what I'm doing now is to marked such items to not be shown to translators. This way they should not show up in future downloads from lokalise. This particular batch of imports has some new translations of older keys that will not show up in the future because they are marked not to be shown to translators.

If desired - I could go an hand-edit all the modified keys so they aren't changed, but it did not seem worth the manual effort.

LGTM.

@marionbarker marionbarker requested review from itsmojo and ps2 August 30, 2025 21:35
Copy link
Collaborator

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marionbarker marionbarker merged commit c2e1a73 into dev Aug 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants