Skip to content

feat: UTRP-87: add feedback to more areas and update feedback form style#761

Merged
Razboy20 merged 9 commits intoLonghorn-Developers:mainfrom
vincent-situ:feat/popup-feedback-flag
Apr 1, 2026
Merged

feat: UTRP-87: add feedback to more areas and update feedback form style#761
Razboy20 merged 9 commits intoLonghorn-Developers:mainfrom
vincent-situ:feat/popup-feedback-flag

Conversation

@vincent-situ
Copy link
Copy Markdown
Contributor

@vincent-situ vincent-situ commented Mar 4, 2026

Old Design:

image image

New Design:
image

image image

This change is Reviewable

@DereC4 DereC4 changed the title feat: UTRP-87: add feedback flag button and adjust header spacing to popup feat: UTRP-87: add feedback to more areas and update feedback form style Mar 4, 2026
@DereC4 DereC4 requested review from DereC4 and lesliewlooi March 4, 2026 20:25
Copy link
Copy Markdown

@lesliewlooi lesliewlooi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@DereC4 DereC4 requested a review from IsaDavRod March 5, 2026 20:31
Copy link
Copy Markdown
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will leave pics and comments in the discord

Copy link
Copy Markdown

@lesliewlooi lesliewlooi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specified changes in Figma

Copy link
Copy Markdown

@lesliewlooi lesliewlooi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated padding and links look good but have another change to make in the CDM:
Left + right padding needs to be increased on this button

Image Image

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an in-page feedback dialog and updates the feedback entry points/styles across the extension UI to match the new design.

Changes:

  • Introduces a reusable useReportIssueDialog hook to open the feedback form in a centered dialog.
  • Replaces “open report window” links with in-app feedback buttons in the Calendar, popup header, and course catalog popup.
  • Restyles ReportIssueMain to the new form layout and adds close behavior for dialog embedding.

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/views/hooks/useReportIssueDialog.tsx New hook to open the feedback form via the dialog system.
src/views/components/injected/CourseCatalogInjectedPopup/CourseCatalogInjectedPopup.tsx Adds a “Send us Feedback!” CTA in the injected course popup.
src/views/components/calendar/TeamLinks.tsx Routes the report link to the new in-page feedback dialog.
src/views/components/calendar/DiningAppPromo.tsx Minor icon styling update (color handling).
src/views/components/calendar/Calendar.tsx Adds new feedback/what’s-new buttons and improves UT Dining promo dismissal race handling.
src/views/components/ReportIssueMain.tsx Redesigns the feedback form UI and supports closing when embedded in a dialog.
src/views/components/PopupMain.tsx Adds a feedback icon button in the popup header and tweaks header button sizing.
src/assets/flag.svg New flag icon asset for feedback affordances.
src/assets/exclamation-mark.svg New exclamation icon asset for “What’s New” affordance.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/views/hooks/useReportIssueDialog.tsx
Comment thread src/views/components/PopupMain.tsx Outdated
Comment thread src/views/components/calendar/DiningAppPromo.tsx Outdated
Comment thread src/views/components/ReportIssueMain.tsx Outdated
Comment thread src/views/components/ReportIssueMain.tsx
Comment thread src/views/components/ReportIssueMain.tsx Outdated
@vincent-situ vincent-situ force-pushed the feat/popup-feedback-flag branch from a8d88f6 to 968be27 Compare March 29, 2026 18:43
@Razboy20
Copy link
Copy Markdown
Member

Made a bunch of changes to align to codestyle, figma, and to our overall general ui style.

UI Changes:

  • Updated feedback form styles (check images below)
  • Changed submit feedback on Calendar to be just a text link
  • Removed the Submit Feedback button on the injected popup, I think it looks awkward
image image image

@DereC4 DereC4 force-pushed the feat/popup-feedback-flag branch from 9c6f7ab to 4d75fad Compare March 30, 2026 23:34
Copy link
Copy Markdown
Member

@DereC4 DereC4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Comment thread src/views/components/ReportIssueMain.tsx
@mymindstorm
Copy link
Copy Markdown
Member

mymindstorm commented Mar 31, 2026

@DereC4 @Razboy20 in the future I encourage you to have fellows handle merge conflicts and quality issues on their own. Although, I understand the need for quick work on this due to the upcoming deadline.

This is a discussion for after the release: To avoid this next semester, we should consider adopting a feature freeze a week or two before the submission deadline. With all these changes at once, it's increasing the likelihood of bugs around reg time. (I've broken an extension for 1M+ people before, it is not fun!)

@Razboy20
Copy link
Copy Markdown
Member

@DereC4 @Razboy20 in the future I encourage you to have fellows handle merge conflicts and quality issues on their own. Although, I understand the need for quick work on this due to the upcoming deadline.

This is a discussion for after the release: To avoid this next semester, we should consider adopting a feature freeze a week or two before the submission deadline. With all these changes at once, it's increasing the likelihood of bugs around reg time. (I've broken an extension for 1M+ people before, it is not fun!)

I 100% agree—I would much rather give constructive criticism and give a full and proper review; I don't like pushing commits on others' PRs personally!

In this specific case however, we really need to push this update out ASAP, so as much as I hate to feel like I'm treading on the work and learning of @vincent-situ in this PR, I hope we can be happy at having a release to show before this registration period starts :)

@Razboy20 Razboy20 force-pushed the feat/popup-feedback-flag branch from 6649d9b to 7d82d10 Compare March 31, 2026 23:37
@Razboy20 Razboy20 force-pushed the feat/popup-feedback-flag branch from 7d82d10 to 82c315d Compare March 31, 2026 23:41
Copy link
Copy Markdown
Member

@Razboy20 Razboy20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Razboy20 partially reviewed 5 files.
Reviewable status: 1 of 17 files reviewed, 1 unresolved discussion (waiting on doprz and vincent-situ).

Copy link
Copy Markdown
Member

@Razboy20 Razboy20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Razboy20 reviewed 16 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on doprz and vincent-situ).

Copy link
Copy Markdown
Member

@Razboy20 Razboy20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Razboy20 resolved 1 discussion and dismissed @doprz from a discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on vincent-situ).

@Razboy20 Razboy20 merged commit 61e2005 into Longhorn-Developers:main Apr 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update feedback form style Add feedback reporting button to more places

8 participants