Skip to content

Conversation

@ReenigneArcher
Copy link
Member

Description

This PR adds some missing giscus attributes. I assume these were not available when giscus was added originally.

Additionally, there is a logic change that allows a local css file for the giscus theme. I tried to test this locally and it requires CORS to be disabled, I am not sure how this would work on a GitHub hosted site, but in any event it allows to specify a theme like /assets/css/giscus.css or any local path that starts with /. Normally giscus will try to get any non full url theme from their own server/api.

https://giscus.app/

Screenshot

image

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher force-pushed the fix/giscus/add-missing-attributes branch from 92a2e6b to 65ccb62 Compare September 13, 2025 19:39
@ReenigneArcher ReenigneArcher force-pushed the fix/giscus/add-missing-attributes branch from 65ccb62 to ce9ebfa Compare September 13, 2025 19:41
@sonarqubecloud
Copy link

@ReenigneArcher ReenigneArcher merged commit 0d65215 into LizardByte:master Sep 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant