Skip to content

feat(macOS): Capture audio on macOS using Tap API #4209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

feat(macOS): Capture audio on macOS using Tap API #4209

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
5bd8e54
wip(macos): add system-wide audio tap support
ThomVanL Aug 28, 2025
74c2cf1
feat(macos): some unit tests
ThomVanL Aug 28, 2025
0c2e096
wip(macos): converter creation now queries device to get accurate info
ThomVanL Aug 28, 2025
48ef28d
wip(macos): refactored setupSystemTap and split into methods
ThomVanL Aug 28, 2025
05c76c1
wip(macos): more unit tests to cover refactored system tap methods
ThomVanL Aug 28, 2025
d594c06
wip(macos): nullability and cleanup return types
ThomVanL Aug 29, 2025
2b0ba99
wip(macos): NS_ASSUME_NONNULL_BEGIN should be included
ThomVanL Aug 29, 2025
1dc8217
wip(macos): added some info log statements
ThomVanL Aug 29, 2025
1a3bc52
wip(macos): doxygen documentation
ThomVanL Aug 29, 2025
cab7da6
wip(macos): added cleanupSystemTapContext instance method to header a…
ThomVanL Aug 29, 2025
a729f78
wip(macos): renamed instance method
ThomVanL Aug 29, 2025
b29445e
fix(macos): add macOS-specific test files only when building tests fo…
ThomVanL Aug 29, 2025
9762651
fix(cmake): add missing newline
ThomVanL Aug 29, 2025
13bc467
style: format C++ code with clang-format
ThomVanL Aug 29, 2025
5aa03e2
fix(macos): improve nil-safety in av_audio microphone code-path
ThomVanL Aug 30, 2025
a847d1f
style(windows): code incorrectly formatted
ThomVanL Aug 30, 2025
6404705
revert: style(windows): code incorrectly formatted
ThomVanL Aug 30, 2025
faa1170
wip(macos): refactor ioprocs to c/c++.
ThomVanL Sep 2, 2025
fc3609b
style(macos): formatting
ThomVanL Sep 2, 2025
b056036
refactor(macos): simplify audio tap to always use stereo configuration
ThomVanL Sep 2, 2025
2c40470
feat(audio): Core Audio tap mute behavior for macOS host audio control.
ThomVanL Sep 3, 2025
1ba9208
fix(audio): mark unused host_audio_enabled parameter as [[maybe_unused]]
ThomVanL Sep 3, 2025
44407a4
Merge branch 'master' into users/thomasvanlaere/feat-macos-ca-taps
ThomVanL Nov 3, 2025
3ce6572
refactor(config): macos_system_wide_audio_tap removed
ThomVanL Nov 3, 2025
fe2ef3f
fix(macos): correct minimum macOS version for Core Audio taps from 14…
ThomVanL Nov 3, 2025
186c21c
feat(macos): use system audio tap on macOS 14+ and update related docs
ThomVanL Nov 3, 2025
db3d2df
fix(audio): add missing host_audio_enabled parameter to Linux audio.
ThomVanL Nov 3, 2025
f667865
fix: gitignore did not end with a newline character.
ThomVanL Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/platform/windows/display_base.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
typedef long NTSTATUS;

// Definition from the WDK's d3dkmthk.h
typedef enum _D3DKMT_GPU_PREFERENCE_QUERY_STATE: DWORD {
typedef enum _D3DKMT_GPU_PREFERENCE_QUERY_STATE : DWORD {
D3DKMT_GPU_PREFERENCE_STATE_UNINITIALIZED, ///< The GPU preference isn't initialized.
D3DKMT_GPU_PREFERENCE_STATE_HIGH_PERFORMANCE, ///< The highest performing GPU is preferred.
D3DKMT_GPU_PREFERENCE_STATE_MINIMUM_POWER, ///< The minimum-powered GPU is preferred.
Expand Down
Loading