Skip to content

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Mar 15, 2025

Description

This PR moves to the official nvapi repo, which did not exist at the time ours was created.

R560+ does not build with Sunshine as is, and unfortunately the R555 version in the official repo is missing the nvapi_interface.h file. See NVIDIA/nvapi#11

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Mar 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.02%. Comparing base (8bfb65e) to head (8c8a6d8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3725      +/-   ##
==========================================
- Coverage   11.32%   11.02%   -0.30%     
==========================================
  Files          92       69      -23     
  Lines       17570    12354    -5216     
  Branches     8238     5987    -2251     
==========================================
- Hits         1989     1362     -627     
+ Misses      13063    10497    -2566     
+ Partials     2518      495    -2023     
Flag Coverage Δ
Linux-AppImage 11.02% <ø> (ø)
Windows-AMD64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 59 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the build/deps/move-nvapi-to-official-nvidia-repo branch from 65bb410 to f9b55fd Compare July 25, 2025 02:55
@ReenigneArcher ReenigneArcher force-pushed the build/deps/move-nvapi-to-official-nvidia-repo branch from f9b55fd to 8c8a6d8 Compare July 25, 2025 03:06
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants