Fixes #1419 - Adjusted X axis name label coordinate calculation when InLineNamePlacement is used#1776
Open
jlimauro wants to merge 1 commit intoLive-Charts:masterfrom
Open
Fixes #1419 - Adjusted X axis name label coordinate calculation when InLineNamePlacement is used#1776jlimauro wants to merge 1 commit intoLive-Charts:masterfrom
jlimauro wants to merge 1 commit intoLive-Charts:masterfrom
Conversation
…lacement option is used. This fixes a bug in which places axis names and labels a top each other when InLineNamePlacement option was used.
Collaborator
|
Hi and thanks for the fix! I tried this long time ago, but the problem when I tested the proposed solution on #1419 it broke other cases (don't exactly remember the case), I know Unit tests pass, this means that we need stronger unit tests. I need more time to merge this fix to ensure nothing else brakes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusted X axis name label coordinate calculation when InLineNamePlacement option is used. This fixes a bug in which places axis names and labels a top each other when InLineNamePlacement option was used. This fixes for both Start and End axis positions.
These changes resolve issue: #1419