Skip to content

[ngssm-data] Parameter partial validity should not be cleared when data source is cleared but not the parameter#390

Merged
LionMarc merged 1 commit into
mainfrom
fix/data_should_not_clear_parameter_validity
Feb 7, 2026
Merged

[ngssm-data] Parameter partial validity should not be cleared when data source is cleared but not the parameter#390
LionMarc merged 1 commit into
mainfrom
fix/data_should_not_clear_parameter_validity

Conversation

@LionMarc
Copy link
Copy Markdown
Owner

@LionMarc LionMarc commented Feb 7, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 7, 2026

Code Coverage

Package Line Rate Branch Rate Health
ngssm-data.src.lib.ngssm-data 97% 85%
ngssm-data.src.lib.ngssm-data.actions 100% 100%
ngssm-data.src.lib.ngssm-data.components 100% 92%
ngssm-data.src.lib.ngssm-data.components.ngssm-auto-reload 100% 95%
ngssm-data.src.lib.ngssm-data.components.ngssm-data-reload-button 97% 98%
ngssm-data.src.lib.ngssm-data.effects 100% 100%
ngssm-data.src.lib.ngssm-data.model 94% 89%
ngssm-data.src.lib.ngssm-data.reducers 100% 100%
ngssm-data.src.lib.ngssm-data.state 100% 100%
ngssm-data.testing.src 86% 90%
ngssm-store.src.lib 95% 98%
ngssm-store.src.lib.actions 80% 100%
ngssm-store.src.lib.feature-state 100% 100%
ngssm-store.src.lib.logging 94% 89%
ngssm-store.testing.src 80% 40%
ngssm-remote-data.src.lib.ngssm-remote-call 88% 94%
ngssm-remote-data.src.lib.ngssm-remote-call.ngssm-remote-call-error 100% 92%
ngssm-remote-data.src.lib.ngssm-remote-call.reducers 100% 100%
ngssm-remote-data.src.lib.remote-data 100% 100%
ngssm-remote-data.src.lib.remote-data.actions 44% 100%
ngssm-remote-data.src.lib.remote-data.components.ngssm-caches 100% 64%
ngssm-remote-data.src.lib.remote-data.components.ngssm-caches-display-button 100% 86%
ngssm-remote-data.src.lib.remote-data.components.ngssm-remote-data-reload-button 100% 84%
ngssm-remote-data.src.lib.remote-data.effects 100% 87%
ngssm-remote-data.src.lib.remote-data.guards 100% 100%
ngssm-remote-data.src.lib.remote-data.model 100% 100%
ngssm-remote-data.src.lib.remote-data.reducers 100% 82%
ngssm-remote-data.src.lib.remote-data.state 83% 100%
ngssm-store.src.lib 92% 85%
ngssm-store.src.lib.actions 50% 100%
ngssm-store.src.lib.feature-state 100% 100%
ngssm-store.src.lib.logging 100% 100%
ngssm-store.testing.src 73% 25%
ngssm-toolkit.src.lib 93% 68%
ngssm-toolkit.src.lib.confirmation-dialog 100% 100%
ngssm-toolkit.src.lib.confirmation-dialog.ngssm-confirmation-dialog 100% 78%
ngssm-toolkit.src.lib.file-picker 100% 78%
ngssm-toolkit.src.lib.mat-dialog 100% 85%
ngssm-toolkit.src.lib.ngssm-help 100% 85%
ngssm-toolkit.src.lib.notification 100% 100%
ngssm-toolkit.src.lib.notification.ngssm-notification-error 100% 78%
ngssm-toolkit.src.lib.notification.ngssm-notification-success 100% 78%
ngssm-toolkit.src.lib.overlay 100% 85%
ngssm-toolkit.src.lib.regex-editor 38% 25%
ngssm-tree.src.lib.ngssm-tree.actions 72% 67%
ngssm-tree.src.lib.ngssm-tree.components.ngssm-breadcrumb 42% 38%
ngssm-tree.src.lib.ngssm-tree.components.ngssm-tree 74% 60%
ngssm-tree.src.lib.ngssm-tree.components.ngssm-tree-search-dialog 67% 54%
ngssm-tree.src.lib.ngssm-tree.effects 15% 17%
ngssm-tree.src.lib.ngssm-tree.model 40% 20%
ngssm-tree.src.lib.ngssm-tree.reducers 55% 43%
ngssm-tree.src.lib.ngssm-tree.state 100% 0%
caching.src.actions 100% 100%
caching.src.model 100% 100%
caching.src.reducers 100% 100%
caching.src.state 100% 100%
caching.testing.src 100% 100%
src.lib 100% 100%
src.lib.actions 100% 100%
src.lib.feature-state 100% 100%
src.lib.logging 100% 100%
testing.src 80% 40%
visibility.src 100% 100%
visibility.src.actions 100% 100%
visibility.src.components 100% 87%
visibility.src.components.ngssm-visibility-toggle-group 100% 92%
visibility.src.reducers 70% 62%
visibility.src.state 100% 100%
visibility.testing.src 100% 100%
ngssm-remote-data.src.lib.ngssm-remote-call 100% 89%
ngssm-remote-data.src.lib.ngssm-remote-call.ngssm-remote-call-error 100% 100%
ngssm-remote-data.src.lib.ngssm-remote-call.reducers 100% 100%
ngssm-remote-data.src.lib.remote-data 100% 100%
ngssm-remote-data.src.lib.remote-data.actions 100% 100%
ngssm-remote-data.src.lib.remote-data.components.ngssm-caches 100% 82%
ngssm-remote-data.src.lib.remote-data.components.ngssm-caches-display-button 100% 100%
ngssm-remote-data.src.lib.remote-data.components.ngssm-remote-data-reload-button 100% 97%
ngssm-remote-data.src.lib.remote-data.effects 100% 95%
ngssm-remote-data.src.lib.remote-data.guards 100% 100%
ngssm-remote-data.src.lib.remote-data.model 100% 100%
ngssm-remote-data.src.lib.remote-data.reducers 100% 96%
ngssm-remote-data.src.lib.remote-data.state 100% 100%
ngssm-remote-data.testing.src 89% 100%
ngssm-store.src.lib 92% 85%
ngssm-store.src.lib.actions 50% 100%
ngssm-store.src.lib.feature-state 100% 100%
ngssm-store.src.lib.logging 100% 100%
ngssm-store.testing.src 85% 50%
ngssm-toolkit.src.lib 93% 68%
ngssm-toolkit.src.lib.confirmation-dialog 100% 100%
ngssm-toolkit.src.lib.confirmation-dialog.ngssm-confirmation-dialog 100% 78%
ngssm-toolkit.src.lib.file-picker 100% 78%
ngssm-toolkit.src.lib.mat-dialog 100% 85%
ngssm-toolkit.src.lib.ngssm-help 100% 85%
ngssm-toolkit.src.lib.notification 100% 100%
ngssm-toolkit.src.lib.notification.ngssm-notification-error 100% 100%
ngssm-toolkit.src.lib.notification.ngssm-notification-success 100% 100%
ngssm-toolkit.src.lib.overlay 100% 85%
ngssm-ace-editor.src.lib 79% 89%
ngssm-ace-editor.src.lib.ngssm-ace-editor 100% 81%
ngssm-shell.src.lib.actions 82% 100%
ngssm-shell.src.lib.components.shell 17% 45%
ngssm-shell.src.lib.components.shell-notification 42% 68%
ngssm-shell.src.lib.components.shell-notification-popup 100% 100%
ngssm-shell.src.lib.components.shell-notifications 69% 90%
ngssm-shell.src.lib.components.side-nav 45% 58%
ngssm-shell.src.lib.components.wrapper 100% 100%
ngssm-shell.src.lib.model 100% 100%
ngssm-shell.src.lib.reducers 14% 23%
ngssm-shell.src.lib.state 100% 100%
ngssm-store.src.lib 49% 60%
ngssm-store.src.lib.actions 50% 100%
ngssm-store.src.lib.feature-state 100% 100%
ngssm-store.src.lib.logging 89% 100%
ngssm-toolkit.src.lib 93% 68%
ngssm-toolkit.src.lib.confirmation-dialog 100% 100%
ngssm-toolkit.src.lib.confirmation-dialog.ngssm-confirmation-dialog 100% 78%
ngssm-toolkit.src.lib.file-picker 100% 78%
ngssm-toolkit.src.lib.mat-dialog 100% 85%
ngssm-toolkit.src.lib.ngssm-help 100% 85%
ngssm-toolkit.src.lib.notification 100% 100%
ngssm-toolkit.src.lib.notification.ngssm-notification-error 100% 78%
ngssm-toolkit.src.lib.notification.ngssm-notification-success 100% 78%
ngssm-toolkit.src.lib.overlay 100% 85%
ngssm-data.src.lib.ngssm-data 25% 0%
ngssm-data.src.lib.ngssm-data.actions 59% 100%
ngssm-data.src.lib.ngssm-data.components 11% 38%
ngssm-data.src.lib.ngssm-data.components.ngssm-auto-reload 5% 16%
ngssm-data.src.lib.ngssm-data.components.ngssm-data-reload-button 2% 6%
ngssm-data.src.lib.ngssm-data.effects 3% 23%
ngssm-data.src.lib.ngssm-data.model 35% 11%
ngssm-data.src.lib.ngssm-data.reducers 4% 15%
ngssm-data.src.lib.ngssm-data.state 100% 100%
ngssm-smusdi.src.lib 100% 67%
ngssm-store.src.lib 12% 15%
ngssm-store.src.lib.actions 50% 100%
ngssm-store.src.lib.feature-state 21% 50%
ngssm-store.src.lib.logging 26% 44%
ngssm-store.testing.src 73% 38%
ngssm-navigation.src.lib 80% 0%
ngssm-navigation.src.lib.actions 100% 100%
ngssm-navigation.src.lib.guards 100% 100%
ngssm-navigation.src.lib.model 100% 100%
ngssm-navigation.src.lib.reducers 7% 20%
ngssm-navigation.src.lib.routing 93% 50%
ngssm-navigation.src.lib.state 100% 100%
ngssm-store.src.lib 100% 92%
ngssm-store.src.lib.actions 50% 100%
ngssm-store.src.lib.feature-state 100% 100%
ngssm-store.src.lib.logging 82% 83%
ngssm-store.testing.src 73% 25%
ngssm-store.src.lib 100% 92%
ngssm-store.src.lib.actions 50% 100%
ngssm-store.src.lib.feature-state 100% 100%
ngssm-store.src.lib.logging 89% 100%
ngssm-store.testing.src 80% 38%
ngssm-toolkit.src.lib 94% 89%
ngssm-toolkit.src.lib.confirmation-dialog 100% 100%
ngssm-toolkit.src.lib.confirmation-dialog.ngssm-confirmation-dialog 100% 100%
ngssm-toolkit.src.lib.file-picker 47% 46%
ngssm-toolkit.src.lib.mat-dialog 100% 85%
ngssm-toolkit.src.lib.ngssm-help 100% 93%
ngssm-toolkit.src.lib.notification 100% 100%
ngssm-toolkit.src.lib.notification.ngssm-notification-error 100% 100%
ngssm-toolkit.src.lib.notification.ngssm-notification-success 100% 100%
ngssm-toolkit.src.lib.overlay 98% 85%
ngssm-ag-grid.src.lib 100% 100%
ngssm-ag-grid.src.lib.actions 100% 100%
ngssm-ag-grid.src.lib.components 100% 92%
ngssm-ag-grid.src.lib.components.action-confirmation-popup 100% 96%
ngssm-ag-grid.src.lib.components.ngssm-actions-cell-renderer 98% 86%
ngssm-ag-grid.src.lib.effects 100% 100%
ngssm-ag-grid.src.lib.reducers 100% 100%
ngssm-ag-grid.src.lib.state 100% 100%
ngssm-ag-grid.testing.src 100% 100%
ngssm-store.src.lib 92% 85%
ngssm-store.src.lib.actions 50% 100%
ngssm-store.src.lib.feature-state 100% 100%
ngssm-store.src.lib.logging 93% 100%
ngssm-store.testing.src 80% 40%
ngssm-toolkit.src.lib 86% 68%
ngssm-toolkit.src.lib.confirmation-dialog 100% 100%
ngssm-toolkit.src.lib.confirmation-dialog.ngssm-confirmation-dialog 100% 78%
ngssm-toolkit.src.lib.file-picker 100% 78%
ngssm-toolkit.src.lib.mat-dialog 100% 85%
ngssm-toolkit.src.lib.ngssm-help 100% 85%
ngssm-toolkit.src.lib.notification 100% 100%
ngssm-toolkit.src.lib.notification.ngssm-notification-error 100% 78%
ngssm-toolkit.src.lib.notification.ngssm-notification-success 100% 78%
ngssm-toolkit.src.lib.overlay 100% 85%
Summary 81% (3954 / 4895) 75% (2471 / 3271)

@LionMarc LionMarc merged commit e93dae0 into main Feb 7, 2026
4 checks passed
@LionMarc LionMarc deleted the fix/data_should_not_clear_parameter_validity branch February 7, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant