Add unit tests and copilot instructions #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add comprehensive tabular unit tests for generate.go functionality - Implement HTTP mocking using github.com/jarcoal/httpmock - Create test fixtures including RSA private key for JWT testing - Add test target to Makefile for running all unit tests - Update go.mod and go.sum with required testing dependencies - Achieve 95.9% code coverage on Generate function - Cover all success and error scenarios including edge cases
- Add new 'test' job that runs unit tests on all events - Modify integration job to only run on push to main or workflow_dispatch - Integration tests no longer run on pull requests
- Add revoke_test.go with tabular tests covering all revoke functionality - Add installations_test.go with comprehensive test coverage - Test successful token revocation with various hostname formats - Test error handling for HTTP status codes (401, 403, 404, 500, etc.) - Test network errors and edge cases - Mock HTTP requests using httpmock library - Follow existing test patterns from generate_test.go - All tests pass with full coverage of implemented features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the project's developer experience by enhancing the testing workflow, and updating dependencies for better unit testing support. The most significant changes include the separation of unit and integration tests in CI, new Makefile targets for running tests, and updated dependencies for mocking and assertions.
Documentation improvements:
.github/copilot-instructions.mdfile outlining project structure, coding standards, unit testing guidelines, and git operation instructions.Testing infrastructure enhancements:
Makefileto include atesttarget for running all unit tests and marked it as a phony target. [1] [2] [3].github/workflows/test.ymlto distinguish between "Unit Tests" and "Integration Tests," running unit tests on all events and integration tests only on pushes tomainor manual dispatches. [1] [2]Dependency management:
go.modrelevant for testing, includinggithub.zerozr99.workers.dev/stretchr/testify,github.com/jarcoal/httpmock, and others.