New metric: CLIP IQA #1931
Merged
New metric: CLIP IQA #1931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
SkafteNicki
requested review from
Borda,
justusschock,
lantiga and
stancld
as code owners
Collaborator
Author
|
@lantiga thanks for the review. That is a really good point, so let me just move in to multimodal instead of image. |
stancld
reviewed
Aug 19, 2023
stancld
reviewed
Aug 19, 2023
stancld
reviewed
Aug 19, 2023
stancld
reviewed
Aug 19, 2023
stancld
reviewed
Aug 19, 2023
stancld
reviewed
Aug 19, 2023
stancld
reviewed
Aug 19, 2023
stancld
reviewed
Aug 19, 2023
stancld
reviewed
Aug 19, 2023
stancld
reviewed
Aug 19, 2023
stancld
reviewed
Aug 19, 2023
stancld
reviewed
Aug 19, 2023
Contributor
stancld
left a comment
stancld
left a comment
There was a problem hiding this comment.
Just left a few comments. Looks good! Thanks for this addition! 🚀
Co-authored-by: Daniel Stancl <[email protected]>
Co-authored-by: Daniel Stancl <[email protected]>
matsumotosan
pushed a commit
to matsumotosan/torchmetrics
that referenced
this pull request
Aug 25, 2023
Co-authored-by: Daniel Stancl <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
CLIPImageQualityAssessmentas new metric to theimagesubpackage.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--1931.org.readthedocs.build/en/1931/