Fsspec is inconsistant when doing fs.ls#3805
Merged
williamFalcon merged 1 commit intoLightning-AI:masterfrom Oct 3, 2020
Merged
Fsspec is inconsistant when doing fs.ls#3805williamFalcon merged 1 commit intoLightning-AI:masterfrom
williamFalcon merged 1 commit intoLightning-AI:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3805 +/- ##
=======================================
+ Coverage 88% 90% +2%
=======================================
Files 110 110
Lines 8873 8617 -256
=======================================
- Hits 7770 7732 -38
+ Misses 1103 885 -218 |
a0175da to
a826859
Compare
Contributor
Author
|
The failing tests seem to be an nvidia mirror issue? |
Contributor
|
Good catch! Did you file an issue for fsspec to fix their HDFS implementation? |
Collaborator
|
Can we get a test for this fix? |
1 similar comment
Collaborator
|
Can we get a test for this fix? |
This was referenced Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
FSSpec, which we use for doing IO which may or may not be local, has some inconsistancies in how it lists files. On local and some remote systems
fs.ls(path)gives a list of strings and others (hdfs for example) it gives a list of dictionaries with the paths and meta data.Switching to fs.listdir(path) seems to give consistent behavior on the platforms I tested. Despite fsspec listing that
lsis an alias forlistdirin their documentation.Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃