build(deps): bump torch & torchvision from 2.8.0 to 2.9.0 in /requirements with compatibility fixes#21300
Conversation
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflow
These checks are required after the changes to 🟢 pytorch_lightning: lit GPU
These checks are required after the changes to 🟢 Benchmarks
These checks are required after the changes to 🟢 fabric: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 lightning_fabric: CPU workflow
These checks are required after the changes to 🟢 lightning_fabric: lit GPU
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 install
These checks are required after the changes to Thank you for your contribution! 💜
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #21300 +/- ##
=======================================
- Coverage 87% 87% -0%
=======================================
Files 269 269
Lines 23809 23810 +1
=======================================
- Hits 20625 20623 -2
- Misses 3184 3187 +3 |
Bumps [torch](https://github.com/pytorch/pytorch) from 2.8.0 to 2.9.0. - [Release notes](https://github.com/pytorch/pytorch/releases) - [Changelog](https://github.com/pytorch/pytorch/blob/main/RELEASE.md) - [Commits](pytorch/pytorch@v2.8.0...v2.9.0) --- updated-dependencies: - dependency-name: torch dependency-version: 2.9.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
578e318 to
0cbd6a3
Compare
|
A newer version of torch exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
There was a problem hiding this comment.
Pull request overview
This PR bumps PyTorch from version 2.8.0 to 2.9.0 and updates the codebase to maintain compatibility with the new version.
Key changes include:
- Updated PyTorch version constraints from
<2.9.0to<2.10.0in base requirements - Refactored version checks from
_TORCH_EQUAL_2_8to_TORCH_GREATER_EQUAL_2_8for broader compatibility - Added workarounds for PyTorch 2.9-specific issues including TorchScript IR crashes with torch_tensorrt
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| requirements/pytorch/base.txt | Updated torch upper bound from <2.9.0 to <2.10.0 |
| requirements/fabric/base.txt | Updated torch upper bound from <2.9.0 to <2.10.0 |
| requirements/typing.txt | Updated pinned torch version from 2.8.0 to 2.9.0 |
| src/lightning/pytorch/utilities/imports.py | Added _TORCH_GREATER_EQUAL_2_8 version check constant |
| tests/tests_pytorch/trainer/test_trainer.py | Replaced _TORCH_EQUAL_2_8 with _TORCH_GREATER_EQUAL_2_8 for xfail condition |
| tests/tests_pytorch/helpers/runif.py | Replaced version-specific checks with _TORCH_GREATER_EQUAL_2_8 for Windows gloo xfail |
| tests/tests_pytorch/models/test_torch_tensorrt.py | Added skipif markers for TorchScript IR due to crashes in PyTorch 2.9 |
| tests/tests_pytorch/conftest.py | Added "InductorSubproc" thread to allowed list for torch.compile compatibility |
| tests/tests_fabric/conftest.py | Added "InductorSubproc" thread to allowed list for torch.compile compatibility |
| src/lightning/fabric/utilities/spike.py | Added type ignore comments for mypy compatibility with PyTorch 2.9 |
| .lightning/workflows/pytorch.yml | Added find-links arguments to pip install for CUDA-specific PyTorch packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ments with compatibility fixes (Lightning-AI#21300)
…ments with compatibility fixes (#21300)
Bumps torch from 2.8.0 to 2.9.0.
Release notes
Sourced from torch's releases.
... (truncated)
Commits
0fabc3bCUDA aarch64 12.6 and 12.8 builds fix triton constraints (#165022)26e023a[MPS] Update OS version in error message (#164949)6f12be2CUDA 13.0 builds fix on Amazon Linux 2023 (#164893)42f0c2cupdate the baseline data for the operator benchmark (#164789)b015422fix cpp extension distributed warning spew (#164785)d4c4307Fix docker build issue after 164575 (#164779)3b57315[ROCm] Increase binary build timeout to 5 hours (300 minutes) (#164770)c74f057Pin conda version for Docker builds (#164579)fd36458[Cherry-Pick] Work Around exposing statically linked libstdc++ CXX11 ABI stro...2f6387e[CherrryPick][2.9] Cherry pick request for `Reapply "Make functionalization V...You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)📚 Documentation preview 📚: https://pytorch-lightning--21300.org.readthedocs.build/en/21300/