Patch for device placement (Reduce host and device syncs)#17334
Merged
carmocca merged 21 commits intoLightning-AI:masterfrom Apr 25, 2023
shanmugamr1992:patch
Merged
Patch for device placement (Reduce host and device syncs)#17334carmocca merged 21 commits intoLightning-AI:masterfrom shanmugamr1992:patch
carmocca merged 21 commits intoLightning-AI:masterfrom
shanmugamr1992:patch
Conversation
shanmugamr1992
requested review from
awaelchli,
carmocca,
justusschock,
tchaton and
williamFalcon
as code owners
for more information, see https://pre-commit.ci
shanmugamr1992
changed the title
Contributor
Author
|
The main idea is to reduce host and device sync. |
carmocca
reviewed
Apr 15, 2023
carmocca
added
logging
Borda
approved these changes
Apr 24, 2023
carmocca
approved these changes
Apr 24, 2023
awaelchli
reviewed
Apr 27, 2023
Comment on lines
+186
to
+187
| # https://pytorch.org/docs/stable/notes/cuda.html#id5 | ||
| ctx = torch.cuda.stream(torch.cuda.Stream()) if torch.cuda.is_available() else nullcontext() |
Contributor
There was a problem hiding this comment.
Should we avoid using the stream if not running on CUDA? Even if there are no known side effects, for sanity I would prefer that.
Contributor
There was a problem hiding this comment.
Good point, yes. We can check the root device type instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist