feat(litserve): Add support for loading TLS certificates for the user #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
requested review from
Borda,
KaelanDt,
andyland,
aniketmaurya,
ethanwharris,
justusschock,
k223kim and
lantiga
as code owners
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
===================================
Coverage 85% 85%
===================================
Files 39 39
Lines 3049 3069 +20
===================================
+ Hits 2588 2607 +19
- Misses 461 462 +1 🚀 New features to boost your workflow:
|
ethanwharris
approved these changes
Jul 28, 2025
| if host not in ["0.0.0.0", "127.0.0.1", "::"]: | ||
| raise ValueError(host_msg) | ||
|
|
||
| kwargs = add_ssl_context_from_env(kwargs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for automatically loading TLS certificates within deployment if they are provided.
Demo:
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃