input schema extraction for MCP server #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd corresponding tests
aniketmaurya
requested review from
Borda,
KaelanDt,
andyland,
ethanwharris,
justusschock,
k223kim,
lantiga and
tchaton
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
====================================
- Coverage 87% 86% -1%
====================================
Files 37 38 +1
Lines 2633 2733 +100
====================================
+ Hits 2288 2351 +63
- Misses 345 382 +37 🚀 New features to boost your workflow:
|
…oving type handling in mcp.py. Add comprehensive tests for type conversion and parameter title extraction in test_mcp.py.
Borda
approved these changes
Jun 10, 2025
…lasses, including definitions and references in the generated schema. Update tests in test_mcp.py to validate new schema structure and add tests for handling complex types and field constraints.
ethanwharris
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
MCP requires users to provide inputSchema in JSON format. We can build this using Pydantic or using the function type hints.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃