add shutdown endpoint w/ test #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumarrah2002
requested review from
Borda,
KaelanDt,
ali-alshaar7,
aniketmaurya,
ethanwharris,
justusschock,
k223kim,
lantiga and
tchaton
as code owners
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
===================================
Coverage 86% 86%
===================================
Files 37 37
Lines 2359 2373 +14
===================================
+ Hits 2033 2046 +13
- Misses 326 327 +1 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Thanks @kumarrah2002!! looks good so far. added a small comment. also can you paste the whole terminal trace after shutdown please? we would want to make sure that it also terminates all the inference processes.
|
Hi @aniketmaurya, is this a good terminal trace? Let me know if you'd like anything else added. I've also added a second POST request in the test with a 400 error code. |
aniketmaurya
approved these changes
May 23, 2025
aniketmaurya
added a commit
that referenced
this pull request
May 23, 2025
This reverts commit 7fcbdfb.
Borda
pushed a commit
that referenced
this pull request
May 23, 2025
This was referenced Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As a user, I want the ability to shutdown a LitServe server programmatically instead of force quitting. This pull request adds a POST endpoint to the Uvicorn server (labeled /shutdown) which terminates the server using FastAPI's built-in
.should_exit()function. A unit test has also been added, which has passed.Fixes Issue #505.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
This was a good challenge for me! I initially had some issues since exceptions were still arising when stopping the server, but I was able to find a way so there were no exceptions.