Skip to content

Update ThingSet SDK to fix stalled MCU on BMS C1 #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinjaeger merged 1 commit into from
Dec 19, 2025
+9 −5
Merged

Update ThingSet SDK to fix stalled MCU on BMS C1 #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/src/data_objects.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,8 @@ THINGSET_ADD_ITEM_BOOL(APP_ID_INPUT, APP_ID_INPUT_CHG_ENABLE, "wChgEnable", &bms
THINGSET_ADD_ITEM_BOOL(APP_ID_INPUT, APP_ID_INPUT_DIS_ENABLE, "wDisEnable", &bms.dis_enable,
THINGSET_ANY_R | THINGSET_ANY_W, 0);

void data_objects_update_conf(enum thingset_callback_reason reason)
int data_objects_update_conf(enum thingset_callback_reason reason,
const struct thingset_data_object *obj)
{
if (reason == THINGSET_CALLBACK_POST_WRITE) {
// ToDo: Validate new settings before applying them
Expand All @@ -269,6 +270,7 @@ void data_objects_update_conf(enum thingset_callback_reason reason)
thingset_storage_save_queued(true);
#endif
}
return 0;
}

int32_t bat_preset(enum bms_cell_type type)
Expand Down
3 changes: 2 additions & 1 deletion app/src/data_objects.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@
/**
* Callback function to be called when conf values were changed
*/
void data_objects_update_conf(enum thingset_callback_reason reason);
int data_objects_update_conf(enum thingset_callback_reason reason,
const struct thingset_data_object *obj);

/**
* Callback function to apply preset parameters for NMC type via ThingSet
Expand Down
5 changes: 3 additions & 2 deletions docs/src/dev/customization.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,12 @@ board-specific ``.conf`` file:

CONFIG_THINGSET_REPORTING_LIVE_ENABLE_PRESET=n

The default period for data publication can be changed with the following Kconfig option:
The default period for data publication can be changed with the following Kconfig option (value in
milliseconds):

.. code-block:: bash

CONFIG_THINGSET_REPORTING_LIVE_PERIOD_PRESET=10
CONFIG_THINGSET_REPORTING_LIVE_PERIOD_PRESET=10000

Shields for UEXT connector
--------------------------
Expand Down
2 changes: 1 addition & 1 deletion west.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ manifest:
- zcbor
- name: thingset-zephyr-sdk
remote: thingset
revision: b9d300777b669cf3830556cb1a7b41c59b0608e2
revision: 5d5c6b031ba543d67a3dc6904ccfc987ebdadc52
path: thingset-zephyr-sdk
import:
name-allowlist:
Expand Down