Skip to content

Update Checkout Action#73

Merged
martinjaeger merged 2 commits intomainfrom
fix-github-actions
Mar 23, 2026
Merged

Update Checkout Action#73
martinjaeger merged 2 commits intomainfrom
fix-github-actions

Conversation

@dmohns
Copy link
Collaborator

@dmohns dmohns commented Mar 23, 2026

Noticed some failing KiBot CI here: #72

Not entirely sure what the issue is. Somehow related to Git submodules. Updating the Github Checkout Action to latest, seems to resolve the issue.

@github-actions
Copy link

github-actions bot commented Mar 23, 2026

Diff between main (5931c7c) and fix-github-actions (8a0fc0c):

@martinjaeger
Copy link
Member

Ah nice, I wanted to look into this. More simple solution than I expected.

Anything missing (because it's still marked as draft)? Or can I merge?

@dmohns
Copy link
Collaborator Author

dmohns commented Mar 23, 2026

Ah nice, I wanted to look into this. More simple solution than I expected.

It was just a shot in the dark 🫣 But after thinking about it more, I think it's not really related to the issue 😂 I noticed https://github.com/LibreSolar/bms-c1/pull/72/changes#diff-07c05d1370d4481c104133c506303351931607ab52014238ef94f7629b525d87 this file might be causing issues.

Anything missing (because it's still marked as draft)? Or can I merge?

I don't think it hurts to merge it, as updating the checkout action should be an improvement anyways.

@dmohns dmohns marked this pull request as ready for review March 23, 2026 11:15
@martinjaeger martinjaeger merged commit c886e4e into main Mar 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants