Merged
Conversation
martinjaeger
approved these changes
Mar 23, 2026
Member
|
Ah nice, I wanted to look into this. More simple solution than I expected. Anything missing (because it's still marked as draft)? Or can I merge? |
Collaborator
Author
It was just a shot in the dark 🫣 But after thinking about it more, I think it's not really related to the issue 😂 I noticed https://github.com/LibreSolar/bms-c1/pull/72/changes#diff-07c05d1370d4481c104133c506303351931607ab52014238ef94f7629b525d87 this file might be causing issues.
I don't think it hurts to merge it, as updating the checkout action should be an improvement anyways. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed some failing KiBot CI here: #72
Not entirely sure what the issue is. Somehow related to Git submodules. Updating the Github Checkout Action to latest, seems to resolve the issue.