This repository was archived by the owner on Feb 12, 2025. It is now read-only.
Fix ripple explorer (de)serialization issues#938
Merged
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
jcoatelen-ledger
changed the title
BertrandD
approved these changes
Jun 27, 2023
Contributor
BertrandD
left a comment
BertrandD
left a comment
There was a problem hiding this comment.
LGTM, assuming it has been tested manually
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes VSD-2389 and VSD-2405
Changes:
ledger_index_minis now returned as a integer object and not a string-integer ; the synchronization fails at fetching the account transactions. Fix: changeledger_index_mintype from string to unsigned int64Amountattribute is missing forAccountDeletetx type. Fix: parseDeliveredAmount, which is there for this tx type instead.Note: I would not suggest to use
delivered_amountwhich seems always returned because I don't know how the parsing would go for other tx types, e.g. ifdelivered_amountis always matchingAmount(even if I suppose they will be always equal).Results:
sync successful, no error at sync, correct amount saved in db