Skip to content
This repository was archived by the owner on Feb 12, 2025. It is now read-only.

VG-13107 feat(BTC): Use cached balance on bitcoin accounts#934

Merged
BertrandD merged 10 commits into
mainfrom
feat/improve_get_balance
Apr 11, 2023
Merged

VG-13107 feat(BTC): Use cached balance on bitcoin accounts#934
BertrandD merged 10 commits into
mainfrom
feat/improve_get_balance

Conversation

@BertrandD
Copy link
Copy Markdown
Contributor

@BertrandD BertrandD commented Feb 22, 2023

Read balance from cached value in bitcoin_accounts
If no cached balance available, compute it (as before)

-> Balance in written by https://github.com/LedgerHQ/lama-bitcoin/pull/566

VG-13107

On update on bitcoin_outputs, the sql trigger updates the account balance;
@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@BertrandD BertrandD changed the title feat(BTC): Use cached balance on bitcoin accounts VG-13107 feat(BTC): Use cached balance on bitcoin accounts Apr 6, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2023

clang-tidy review says "All clean, LGTM! 👍"

Comment thread core/src/wallet/bitcoin/database/BitcoinLikeUTXODatabaseHelper.cpp
@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Copy Markdown
Contributor

@jcoatelen-ledger jcoatelen-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BertrandD BertrandD merged commit 45c9428 into main Apr 11, 2023
@BertrandD BertrandD deleted the feat/improve_get_balance branch April 11, 2023 09:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants