Skip to content
This repository was archived by the owner on Feb 12, 2025. It is now read-only.

Add option to use static address#926

Merged
BertrandD merged 3 commits into
mainfrom
feat/static_address
Dec 7, 2022
Merged

Add option to use static address#926
BertrandD merged 3 commits into
mainfrom
feat/static_address

Conversation

@BertrandD
Copy link
Copy Markdown
Contributor

Static receive & change address for regulated accounts

Static receive & change address for regulated accounts
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 5, 2022

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 6, 2022

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Copy Markdown
Contributor

@twilgenbus-ledger twilgenbus-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Note-for-another-PR: I wonder if CommonBitcoinLikeKeychains::getFreshAddress(BitcoinLikeKeychain::KeyPurpose purpose) should be calling
CommonBitcoinLikeKeychains::getFreshAddresses(BitcoinLikeKeychain::KeyPurpose purpose, size_t n)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 6, 2022

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Copy Markdown
Contributor

@jcoatelen-ledger jcoatelen-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@BertrandD BertrandD merged commit 73ee9e2 into main Dec 7, 2022
@BertrandD BertrandD deleted the feat/static_address branch December 7, 2022 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants