Allow to use Long Press to open select box + DirectSelect overlay takes same size as underlying child#24
Open
viktar-d wants to merge 6 commits intoLanarsInc:masterfrom
Open
Allow to use Long Press to open select box + DirectSelect overlay takes same size as underlying child#24viktar-d wants to merge 6 commits intoLanarsInc:masterfrom
viktar-d wants to merge 6 commits intoLanarsInc:masterfrom
Conversation
…ct_select is used in a scrollable container
…tion only on the bottom to do not hover all content
viktar-d
commented
Dec 4, 2020
Author
viktar-d
left a comment
viktar-d
left a comment
There was a problem hiding this comment.
PR is ready, please review. Will be glad to work on your comments if something is not yet fully complete from your point of view
viktar-d
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usable in cases when direct_select is used in a scrollable container, ex. in bottom sheet. With default configuration there is no possibility to close bottom sheet by swipe down gesture as direct_select catches the tapDown and shows the select box. Same behaviour on any screen with a scroll when start scrolling from the position of direct_select.