Skip to content

Update to polkadot-v0.9.27#51

Merged
realnimish merged 9 commits intomainfrom
bump-polkadot-v0.9.27
Aug 23, 2022
Merged

Update to polkadot-v0.9.27#51
realnimish merged 9 commits intomainfrom
bump-polkadot-v0.9.27

Conversation

@realnimish
Copy link
Copy Markdown
Member

@realnimish realnimish commented Aug 22, 2022

@realnimish realnimish requested a review from extraymond August 22, 2022 14:55
Copy link
Copy Markdown
Contributor

@extraymond extraymond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have question about changing into_account to into_account_truncating, while it might works since we're just getting the account_id from PalletId,

Semantically into_account().expect("infailable") should be better.

@realnimish realnimish requested a review from extraymond August 23, 2022 07:12
@realnimish realnimish merged commit c11e543 into main Aug 23, 2022
@realnimish realnimish deleted the bump-polkadot-v0.9.27 branch September 2, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants