Skip to content

Fix missing sub-params in odg list #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sveinse merged 1 commit into from
Apr 1, 2025
Merged

Fix missing sub-params in odg list #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/objdictgen/printing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,16 +227,22 @@ def format_od_object(
if index in node.Dictionary:
values = node.GetEntry(index, aslist=True, compute=not raw)
else:
# Fill the values with N/A if the entry is not present
values = ['__N/A__'] * len(obj["values"])

if index in node.ParamsDictionary:
# FIXME: Is there a risk that this return less than the length of
# dictionary values?
params = node.GetParamsEntry(index, aslist=True)
else:
params = [maps.DEFAULT_PARAMS] * len(obj["values"])
params = [maps.DEFAULT_PARAMS] * len(values)

# For mypy to ensure that values and entries are lists
assert isinstance(values, list) and isinstance(params, list)

infos = []
for i, (value, param) in enumerate(zip(values, params)):
# The strict=True will capture if the values and params are not the same
for i, (value, param) in enumerate(zip(values, params, strict=True)):

# Prepare data for printing
info = node.GetSubentryInfos(index, i)
Expand Down