LibMedia: Signal EOF to decoders in the data providers #6688
+143
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All our current demuxers have these constant for an entire track, so we don't need to get them for every frame we output.
This is used by FFmpeg's H.264 decoder to determine when to output any buffered frames after data runs out.
This lets the FFmpeg H.264 decoder know when we've reached the end of the available data, so that it will output the remaining buffered video frames. Not sure why it needs this signal to output the buffered frames, but surely there's a good reason. :^)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets the FFmpeg H.264 decoder know when we've reached the end of the available data, so that it will output the remaining buffered video frames.
Not sure why it needs this signal to output the buffered frames, but surely there's a good reason. :^)
Fixes an issue where the second video on the Dioxus v0.7.0 release notes was not displaying the final few frames.