LibWeb: A couple of animation fixes/cleanups #6642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtkinsSJ
reviewed
Oct 30, 2025
Calme1709
force-pushed
the
animations-fixes
branch
from
fa401e4 to
8c25460
Compare
AtkinsSJ
approved these changes
Oct 31, 2025
We were doing this manually within `Document::update_layout()` and `CSSStyleProperties::get_direct_property()` but we should do it for all callers of `Document::update_style()`
There were a couple places that we had special handling for the `all` property but since d31a58a was merged we can treat it the same as any other shorthand
Gains us 21 WPT tests
Pending style updates can influence this value
Calme1709
force-pushed
the
animations-fixes
branch
from
8c25460 to
3717773
Compare
|
Rebased to latest master |
kalenikaliaksandr
merged commit ef8dcb2
into
LadybirdBrowser:master
14 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details