Skip to content

Conversation

@F3n67u
Copy link
Contributor

@F3n67u F3n67u commented Sep 22, 2025

Some steps were not updated with tc39/ecma262#3057. This patch syncs the remaining changes.

@F3n67u F3n67u marked this pull request as draft September 22, 2025 23:43
@F3n67u F3n67u force-pushed the sync-more-spec-changes-import-attributes branch 2 times, most recently from d932e5c to 2e14c54 Compare September 23, 2025 18:22
@F3n67u F3n67u marked this pull request as ready for review September 23, 2025 22:20
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Oct 15, 2025
@gmta gmta removed the stale label Oct 16, 2025
@F3n67u F3n67u force-pushed the sync-more-spec-changes-import-attributes branch from 2e14c54 to c295c4f Compare October 20, 2025 23:38
Some steps were not updated with tc39/ecma262#3057. This patch
syncs the remaining changes.
@F3n67u F3n67u force-pushed the sync-more-spec-changes-import-attributes branch from c295c4f to f1c9adf Compare October 22, 2025 02:43
@F3n67u
Copy link
Contributor Author

F3n67u commented Oct 22, 2025

@gmta I ran test262 on both my local master branch and this branch.
Both runs show the same diff result against libjs-data:

master vs libjs-data

./per_file_result_diff.py -o ../libjs-data/test262/per-file-master.json -n master.json                                  
Duration:
     +19.86s

Summary:
    Diff Tests:
        +1 ✅   +1 💀    -2 💥️   

Diff Tests:
    test/staging/sm/String/replace-math.js    💥️ -> 💀
    test/staging/sm/regress/regress-610026.js 💥️ -> ✅

this branch vs libjs-data

./per_file_result_diff.py -o ../libjs-data/test262/per-file-master.json -n sync-more-spec-changes-import-attributes.json
Duration:
     +32.35s

Summary:
    Diff Tests:
        +1 ✅   +1 💀    -2 💥️   

Diff Tests:
    test/staging/sm/String/replace-math.js    💥️ -> 💀
    test/staging/sm/regress/regress-610026.js 💥️ -> ✅

The diffs are identical between my local master and this branch, so it seems there are no new test262 differences introduced by my changes.

However, I’m wondering why there’s still a diff between my local master run and libjs-data, since libjs-data should already reflect Ladybird’s master, and my fork’s master is fully up to date with upstream.

@gmta gmta merged commit 61c36e2 into LadybirdBrowser:master Oct 22, 2025
9 checks passed
@F3n67u F3n67u deleted the sync-more-spec-changes-import-attributes branch October 22, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants