fix: enviroment -> environment#219
Merged
Lachee merged 2 commits intoLachee:masterfrom Jul 26, 2023
CanadaHonk:patch-1
Merged
Conversation
Lachee
requested changes
Nov 26, 2022
Owner
Lachee
left a comment
Lachee
left a comment
There was a problem hiding this comment.
I feel like to prevent this being a breaking change, we should just deprecate the old Enviroment and make it point to Environment.
Additionally, is there a reason for this configuration to have public setters? Does Netwonsoft.JSON require those? I cannot remember.
This was referenced Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technically API breaking since key changes but fixes misreading from config READY response and in a few other files.