fix: AWTGLCanvas gives error when activating sRGB #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 16, 2024 11:22
SWinxy
requested changes
Dec 16, 2024
Collaborator
SWinxy
left a comment
SWinxy
left a comment
There was a problem hiding this comment.
Looks good; see comments.
Author
|
Fixes applied... |
Collaborator
|
Misread, my bad. I squashed and merged the commits but I appear to have messed something up and your GitHub isn't being properly credited in the log. Thank you so much for your contributions. I can try again to get the commit to link to your account, if you want, but Git is not my expertise. |
Collaborator
|
GitHub doesn't recognize 7043714 as being associated with this PR; closing as 'not merged' but this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #78, it seems that the extensions do not check for the possibility of the
WGL_ARB_framebuffer_sRGBoption (ARB extension) and that throws an exception, I would like you to check that.