Skip to content

Require sacc 2.1 or newer#564

Merged
marcpaterno merged 1 commit into
masterfrom
require-sacc-2.1
Oct 16, 2025
Merged

Require sacc 2.1 or newer#564
marcpaterno merged 1 commit into
masterfrom
require-sacc-2.1

Conversation

@marcpaterno
Copy link
Copy Markdown
Collaborator

@marcpaterno marcpaterno commented Oct 16, 2025

Description

This PR moves us to a newer version of Sacc, to get a fix for a bug that prevents writing FITS-format Sacc files containing large covariance matrices (with more than 999 columns).

Type of change

Please delete the bullet items below that do not apply to this pull request.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.

  • I have run bash pre-commit-check and fixed any issues
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have 100% test coverage for my changes (please check this after the CI system has verified the coverage)

@marcpaterno marcpaterno requested a review from vitenti October 16, 2025 15:13
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (58ae1b8) to head (abfa58e).
⚠️ Report is 94 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #564   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files          66       66           
  Lines        5984     5984           
  Branches      703      703           
=======================================
  Hits         5984     5984           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marcpaterno marcpaterno merged commit 12b530c into master Oct 16, 2025
11 checks passed
@marcpaterno marcpaterno deleted the require-sacc-2.1 branch October 16, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants