Skip to content

Use hdf5#559

Merged
marcpaterno merged 15 commits into
masterfrom
use-hdf5
Oct 8, 2025
Merged

Use hdf5#559
marcpaterno merged 15 commits into
masterfrom
use-hdf5

Conversation

@marcpaterno
Copy link
Copy Markdown
Collaborator

@marcpaterno marcpaterno commented Oct 5, 2025

Description

This PR adds a tool to translate between FITS and HDF5 format for SACC files.
It introduces a general SACC reading function that deals with both file formats.
It also switches most tests, tutorials and examples to use HDF5 rather than FITS files for SACC data.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Refactoring

Checklist:

The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.

  • I have run bash pre-commit-check and fixed any issues
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have 100% test coverage for my changes (please check this after the CI system has verified the coverage)

@marcpaterno marcpaterno requested a review from vitenti October 5, 2025 16:36
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (99805a5) to head (116ca15).
⚠️ Report is 96 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #559   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files          50       50           
  Lines        5116     5131   +15     
  Branches      580      581    +1     
=======================================
+ Hits         5116     5131   +15     
Files with missing lines Coverage Δ
firecrown/ccl_factory.py 100.0% <ø> (ø)
firecrown/likelihood/factories.py 100.0% <100.0%> (ø)
firecrown/likelihood/two_point.py 100.0% <ø> (ø)
firecrown/likelihood/weak_lensing.py 100.0% <ø> (ø)
firecrown/metadata_functions.py 100.0% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marcpaterno marcpaterno merged commit 8e9f52c into master Oct 8, 2025
11 checks passed
@marcpaterno marcpaterno deleted the use-hdf5 branch October 8, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants