Skip to content

Alter test to avoid mypy error#546

Merged
marcpaterno merged 1 commit into
masterfrom
fix_mypy_error
Sep 17, 2025
Merged

Alter test to avoid mypy error#546
marcpaterno merged 1 commit into
masterfrom
fix_mypy_error

Conversation

@marcpaterno
Copy link
Copy Markdown
Collaborator

@marcpaterno marcpaterno commented Sep 17, 2025

Description

mypy 1.18.1 is complaining about comparison of Enum aliases using is.
The use of is is actually correct, but since mypy is now complaining about it, this PR changes the test to use == instead.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.

  • I have run bash pre-commit-check and fixed any issues
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have 100% test coverage for my changes (please check this after the CI system has verified the coverage)

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (4616cb2) to head (33a2b8a).
⚠️ Report is 108 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #546   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files          49       49           
  Lines        4973     4973           
  Branches      564      564           
=======================================
  Hits         4973     4973           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marcpaterno marcpaterno merged commit 8caa367 into master Sep 17, 2025
10 checks passed
@marcpaterno marcpaterno deleted the fix_mypy_error branch September 17, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant