V1.11#523
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR prepares release 1.11 by updating the version numbers across documentation, tests, and configuration while also fixing several type issues flagged by mypy.
- Updated version strings from "1.11.0a0" to "1.11.0" in documentation and tests.
- Fixed type errors by coercing numpy.random.normal outputs to np.array and explicitly casting indices in the likelihood module.
- Adjusted CI configuration to disable auto-activation of the base environment.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tutorial/two_point_generators.qmd | Updated version comment to reflect 1.11.0 |
| tutorial/introduction_to_firecrown.qmd | Updated subtitle with the new version number |
| tests/test_version.py | Updated version test to match new version format |
| tests/test_cluster_mass_richness.py | Refactored local variable names to improve clarity for array inputs |
| tests/metadata/test_metadata_two_point_sacc.py | Coerced outputs from np.random.normal to np.array for mypy compatibility |
| tests/conftest.py | Applied similar np.array coercions for type consistency |
| firecrown/version.py | Changed FIRECROWN_PATCH from a string to an integer to reflect the release |
| firecrown/likelihood/gaussfamily.py | Cast indices to int for proper indexing in covariance construction |
| docs/conf.py | Updated the release number documentation |
| .github/workflows/ci.yml | Updated CI configuration to disable auto-activation of the base environment |
Comments suppressed due to low confidence (3)
firecrown/version.py:11
- Changing the patch version from a string to an integer updates the version format; please verify that all dependent components or scripts correctly handle the new numeric patch value.
FIRECROWN_PATCH = 0
.github/workflows/ci.yml:33
- Disabling auto-activation of the base environment may affect how subsequent CI commands run; please ensure that this change is compatible with all parts of your CI setup.
auto-activate-base: false
firecrown/likelihood/gaussfamily.py:319
- Explicitly casting each index to int ensures proper indexing into cov_index_map; please verify that all values in stat.sacc_indices are valid and that this conversion does not mask any underlying issues with data types.
temp = [self.cov_index_map[int(idx)] for idx in stat.sacc_indices]
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #523 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 49 49
Lines 4773 4773
Branches 531 531
=======================================
Hits 4773 4773
🚀 New features to boost your workflow:
|
vitenti
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the version numbers in preparation for release 1.11.
It also fixes some typing problems pointed out by the current version of
mypy.Type of change
Please delete the bullet items below that do not apply to this pull request.
Checklist:
The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.
bash pre-commit-checkand fixed any issues