Skip to content

V1.11#523

Merged
marcpaterno merged 8 commits into
masterfrom
v1.11
Jun 9, 2025
Merged

V1.11#523
marcpaterno merged 8 commits into
masterfrom
v1.11

Conversation

@marcpaterno
Copy link
Copy Markdown
Collaborator

@marcpaterno marcpaterno commented Jun 9, 2025

Description

This PR changes the version numbers in preparation for release 1.11.
It also fixes some typing problems pointed out by the current version of mypy.

Type of change

Please delete the bullet items below that do not apply to this pull request.

  • New feature (non-breaking change which adds functionality)

Checklist:

The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.

  • I have run bash pre-commit-check and fixed any issues
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have 100% test coverage for my changes (please check this after the CI system has verified the coverage)

@marcpaterno marcpaterno requested review from Copilot and vitenti June 9, 2025 19:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares release 1.11 by updating the version numbers across documentation, tests, and configuration while also fixing several type issues flagged by mypy.

  • Updated version strings from "1.11.0a0" to "1.11.0" in documentation and tests.
  • Fixed type errors by coercing numpy.random.normal outputs to np.array and explicitly casting indices in the likelihood module.
  • Adjusted CI configuration to disable auto-activation of the base environment.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tutorial/two_point_generators.qmd Updated version comment to reflect 1.11.0
tutorial/introduction_to_firecrown.qmd Updated subtitle with the new version number
tests/test_version.py Updated version test to match new version format
tests/test_cluster_mass_richness.py Refactored local variable names to improve clarity for array inputs
tests/metadata/test_metadata_two_point_sacc.py Coerced outputs from np.random.normal to np.array for mypy compatibility
tests/conftest.py Applied similar np.array coercions for type consistency
firecrown/version.py Changed FIRECROWN_PATCH from a string to an integer to reflect the release
firecrown/likelihood/gaussfamily.py Cast indices to int for proper indexing in covariance construction
docs/conf.py Updated the release number documentation
.github/workflows/ci.yml Updated CI configuration to disable auto-activation of the base environment
Comments suppressed due to low confidence (3)

firecrown/version.py:11

  • Changing the patch version from a string to an integer updates the version format; please verify that all dependent components or scripts correctly handle the new numeric patch value.
FIRECROWN_PATCH = 0

.github/workflows/ci.yml:33

  • Disabling auto-activation of the base environment may affect how subsequent CI commands run; please ensure that this change is compatible with all parts of your CI setup.
auto-activate-base: false

firecrown/likelihood/gaussfamily.py:319

  • Explicitly casting each index to int ensures proper indexing into cov_index_map; please verify that all values in stat.sacc_indices are valid and that this conversion does not mask any underlying issues with data types.
temp = [self.cov_index_map[int(idx)] for idx in stat.sacc_indices]

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (94d3424) to head (420b45b).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #523   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files          49       49           
  Lines        4773     4773           
  Branches      531      531           
=======================================
  Hits         4773     4773           
Files with missing lines Coverage Δ
firecrown/likelihood/gaussfamily.py 100.0% <100.0%> (ø)
firecrown/version.py 100.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marcpaterno marcpaterno merged commit 7cfd29c into master Jun 9, 2025
10 checks passed
@marcpaterno marcpaterno deleted the v1.11 branch June 9, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants