Skip to content

Change default alphag for number counts to 0#514

Merged
marcpaterno merged 1 commit into
masterfrom
issue_507
Apr 28, 2025
Merged

Change default alphag for number counts to 0#514
marcpaterno merged 1 commit into
masterfrom
issue_507

Conversation

@marcpaterno
Copy link
Copy Markdown
Collaborator

@marcpaterno marcpaterno commented Apr 28, 2025

Description

This PR changes the default value of alphag for the number counts linear bias from 1 to 0.
This is desired because the growth factor is already included in the power spectrum.
A alphag value of 0 thus does not additional correction.

Fixes #507

Type of change

Please delete the bullet items below that do not apply to this pull request.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.

  • I have run bash pre-commit-check and fixed any issues
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have 100% test coverage for my changes (please check this after the CI system has verified the coverage)

@marcpaterno marcpaterno requested review from Copilot and vitenti April 28, 2025 20:48
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue in the number counts likelihood by correcting the default value of the growth function exponent (alphag) from 1.0 to 0.0 so that the additional growth correction is removed. The change helps ensure that the growth factor is not applied twice when computing the bias.

Comments suppressed due to low confidence (1)

firecrown/likelihood/number_counts.py:84

  • The default value of 'alphag' has been updated to 0.0, which is in line with the intended correction. Verify that tests and any related documentation are updated accordingly to reflect this change.
LINEAR_BIAS_DEFAULT_ALPHAG = 0.0

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (7c980b5) to head (6e4d12d).
⚠️ Report is 17 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #514   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files          50       50           
  Lines        4775     4775           
  Branches      532      532           
=======================================
  Hits         4775     4775           
Files with missing lines Coverage Δ
firecrown/likelihood/number_counts.py 100.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marcpaterno marcpaterno merged commit 4290e41 into master Apr 28, 2025
9 checks passed
@marcpaterno marcpaterno deleted the issue_507 branch April 28, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linear galaxy bias scaling

3 participants