Change default alphag for number counts to 0#514
Merged
Conversation
vitenti
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue in the number counts likelihood by correcting the default value of the growth function exponent (alphag) from 1.0 to 0.0 so that the additional growth correction is removed. The change helps ensure that the growth factor is not applied twice when computing the bias.
Comments suppressed due to low confidence (1)
firecrown/likelihood/number_counts.py:84
- The default value of 'alphag' has been updated to 0.0, which is in line with the intended correction. Verify that tests and any related documentation are updated accordingly to reflect this change.
LINEAR_BIAS_DEFAULT_ALPHAG = 0.0
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #514 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 50 50
Lines 4775 4775
Branches 532 532
=======================================
Hits 4775 4775
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the default value of
alphagfor the number counts linear bias from 1 to 0.This is desired because the growth factor is already included in the power spectrum.
A
alphagvalue of 0 thus does not additional correction.Fixes #507
Type of change
Please delete the bullet items below that do not apply to this pull request.
Checklist:
The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.
bash pre-commit-checkand fixed any issues