Skip to content

Minor updates to make firecrown tests run with SACC 1.0.#513

Merged
vitenti merged 2 commits into
masterfrom
new_sacc
Apr 28, 2025
Merged

Minor updates to make firecrown tests run with SACC 1.0.#513
vitenti merged 2 commits into
masterfrom
new_sacc

Conversation

@vitenti
Copy link
Copy Markdown
Collaborator

@vitenti vitenti commented Apr 27, 2025

This will work when/if the PR for SACC backward compatibility is accepted and a new release is made.

Description

A few warning messages were updated in the new SACC version. This PR updates them so the tests can run. This makes firecrown required new SACC version.

Type of change

Please delete the bullet items below that do not apply to this pull request.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.

  • I have run bash pre-commit-check and fixed any issues
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have 100% test coverage for my changes (please check this after the CI system has verified the coverage)

vitenti added 2 commits April 27, 2025 12:09
This will work when/if the PR for SACC backward compatibility is accepted and a new relase is made.
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (5ff5afd) to head (7005050).
⚠️ Report is 18 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #513   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files          50       50           
  Lines        4775     4775           
  Branches      532      532           
=======================================
  Hits         4775     4775           
Files with missing lines Coverage Δ
firecrown/ccl_factory.py 100.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vitenti vitenti requested a review from marcpaterno April 27, 2025 18:20
@vitenti vitenti marked this pull request as ready for review April 27, 2025 18:20
@vitenti vitenti merged commit 7c980b5 into master Apr 28, 2025
9 checks passed
@vitenti vitenti deleted the new_sacc branch April 28, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants