Skip to content

Issue 330#497

Merged
marcpaterno merged 8 commits into
masterfrom
issue_330
Mar 26, 2025
Merged

Issue 330#497
marcpaterno merged 8 commits into
masterfrom
issue_330

Conversation

@marcpaterno
Copy link
Copy Markdown
Collaborator

@marcpaterno marcpaterno commented Mar 25, 2025

Description

This PR is intended to resolve issue #330. It provides the CCLSplineParams class, which is a pydantic dataclass -- and thus can be constructed from a YAML document. An object of this type can be given to the constructor of the CCLFactory to control all of the configurable spline parameters in CCL.

Fixes #330

Type of change

Please delete the bullet items below that do not apply to this pull request.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.

  • I have run bash pre-commit-check and fixed any issues
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have 100% test coverage for my changes (please check this after the CI system has verified the coverage)

@marcpaterno marcpaterno requested a review from vitenti March 25, 2025 19:07
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (de6ba1b) to head (b8ad013).
Report is 21 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #497   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files          50       50           
  Lines        4608     4676   +68     
  Branches      507      516    +9     
=======================================
+ Hits         4608     4676   +68     
Files with missing lines Coverage Δ
firecrown/ccl_factory.py 100.0% <100.0%> (ø)
firecrown/likelihood/weak_lensing.py 100.0% <ø> (ø)
firecrown/models/cluster/abundance.py 100.0% <100.0%> (ø)
firecrown/models/cluster/deltasigma.py 100.0% <100.0%> (ø)
firecrown/models/two_point.py 100.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marcpaterno marcpaterno merged commit e209ba3 into master Mar 26, 2025
@marcpaterno marcpaterno deleted the issue_330 branch March 26, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Passing higher precision settings from CCL

2 participants