Skip to content

Remove stub of omega g usage#492

Merged
vitenti merged 3 commits into
masterfrom
remove_stub_of_omega_g_usage
Feb 18, 2025
Merged

Remove stub of omega g usage#492
vitenti merged 3 commits into
masterfrom
remove_stub_of_omega_g_usage

Conversation

@marcpaterno
Copy link
Copy Markdown
Collaborator

@marcpaterno marcpaterno commented Feb 18, 2025

Description

Firecrown's support of Omega_g has always been just a stub. It could be set, but then was not used for anything. This commit removes the stub usage.

Any user code that had set Omega_g would have do so with no effect, while perhaps expecting that the provided value actually was used.

Type of change

Please delete the bullet items below that do not apply to this pull request.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.

  • I have run bash pre-commit-check and fixed any issues
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have 100% test coverage for my changes (please check this after the CI system has verified the coverage)

@marcpaterno marcpaterno requested a review from vitenti February 18, 2025 18:05
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (78c7c8b) to head (435e754).
Report is 22 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #492   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files          55       55           
  Lines        4331     4329    -2     
  Branches      468      468           
=======================================
- Hits         4331     4329    -2     
Files with missing lines Coverage Δ
firecrown/connector/mapping.py 100.0% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vitenti vitenti merged commit 6095a34 into master Feb 18, 2025
@vitenti vitenti deleted the remove_stub_of_omega_g_usage branch February 18, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants