Skip to content

Adding support for TwoPointMeasurement filters.#479

Merged
vitenti merged 25 commits into
masterfrom
data_filters
Feb 13, 2025
Merged

Adding support for TwoPointMeasurement filters.#479
vitenti merged 25 commits into
masterfrom
data_filters

Conversation

@vitenti
Copy link
Copy Markdown
Collaborator

@vitenti vitenti commented Jan 8, 2025

Description

This PR introduces a filter system for TwoPointMeasurements.
This is required to finish the transition for the new create_ready framework.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.

  • I have run bash pre-commit-check and fixed any issues
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have 100% test coverage for my changes (please check this after the CI system has verified the coverage)

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (da7bb3a) to head (5cc7802).
Report is 23 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #479    +/-   ##
========================================
  Coverage   100.0%   100.0%            
========================================
  Files          55       55            
  Lines        4202     4331   +129     
  Branches      448      468    +20     
========================================
+ Hits         4202     4331   +129     
Files with missing lines Coverage Δ
firecrown/data_functions.py 100.0% <100.0%> (ø)
firecrown/generators/inferred_galaxy_zdist.py 100.0% <100.0%> (ø)
firecrown/likelihood/factories.py 100.0% <100.0%> (ø)
firecrown/metadata_functions.py 100.0% <100.0%> (ø)
firecrown/metadata_types.py 100.0% <ø> (ø)
firecrown/utils.py 100.0% <100.0%> (ø)
firecrown/version.py 100.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vitenti vitenti marked this pull request as ready for review February 11, 2025 17:28
@vitenti vitenti requested a review from marcpaterno February 11, 2025 17:28
@vitenti vitenti merged commit 9613906 into master Feb 13, 2025
@vitenti vitenti deleted the data_filters branch February 13, 2025 11:43
@vitenti vitenti mentioned this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants