Fix for checkout ui session tokens #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeroendelau
reviewed
Oct 1, 2025
Contributor
jeroendelau
left a comment
jeroendelau
left a comment
There was a problem hiding this comment.
All good, but does this pass the tests? Probably they also need a small edit.
Owner
|
@blazerunner44 thanks for the PR, I've kicked off the tests but can you confirm this is backwards compatible in your testing? |
Kyon147
approved these changes
Nov 7, 2025
Owner
Kyon147
left a comment
Kyon147
left a comment
There was a problem hiding this comment.
This looks good for now - the docs look like they are still out of date https://shopify.dev/docs/api/checkout-ui-extensions/latest/apis/session-token but as you say it does assume that checkout extension do not have a sid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for an issue discussed on PR #329
It appears Shopify now issues the
issfield on Checkout UI session tokens, breaking the currentdetermineTokenSourcemethod.This PR removes the
issfield check and relys solely on the presence of thesidfield to determine if the SessionToken comes from the app or checkout ui.According to the Shopify documentation, they define the sid as:
sid: A unique session ID per user and app.Shopify docs
Therefore, it makes sense that a sid wouldn't be issued for a checkout/account UI extension as there's no authenticated Shopify user using the app.