Skip to content

CLI: --url-file is declared and documented but never read #604

Closed

Description

@thomas-stegemann

--url-file is declared on the CLI and documented in the setup guide, but nothing ever reads it. Passing it is silently a no-op.

Evidence

Declared as an option: src/Kuestenlogik.Bowire.Tool/Cli/BowireCli.cs:100.

Documented as a working feature: docs/setup/sidecar.md:98-117 describes pointing Bowire at a file of URLs.

Never consumed: src/Kuestenlogik.Bowire.Tool/Configuration/BowireConfiguration.cs extracts only --url / -u (lines 61-62 and 273-292). There is no read of --url-file anywhere in the configuration path.

Found during the 2026-08-21 audit sweep while checking #44 (sidecar packaging), which is a different issue — the docs walkthrough there is genuinely done.

Why this is worse than a missing feature

A flag that does not exist fails loudly: the CLI rejects it and the operator tries something else. A flag that parses and does nothing fails silently — the operator passes a file of twenty URLs, sees Bowire start, and finds none of them discovered. Nothing in the output says the file was ignored, and the documentation says it should have worked.

What to do

Either wire it up or take it out; both are defensible, and leaving it as-is is not.

Wire it up. Read the file in BowireConfiguration, one URL per line, blank lines and # comments skipped, and merge the entries into the same list --url fills. A missing or unreadable file should be an error at startup, not a silent empty list — the whole point of this issue is that quiet is the wrong failure mode.

Or remove it. Drop the option from BowireCli.cs and the section from docs/setup/sidecar.md. A rejected unknown flag is honest.

Acceptance criteria

  • A decision recorded: wired up, or removed
  • If wired: --url-file entries reach discovery exactly as --url entries do, and a mix of both works
  • If wired: a missing/unreadable file, and a file with no usable lines, both fail with a message naming the path
  • If wired: blank lines and # comments are skipped, and this is covered by a test
  • If removed: no mention survives in the CLI or in docs/setup/sidecar.md
  • Either way, a test would have caught this — the option's behaviour is pinned

Related

Activity

  1. added a commit that references this issue on Aug 21, 2026
  2. thomas-stegemann commented on Aug 24, 2026

    @thomas-stegemann
    MemberAuthor

    Erledigt — Audit-Sweep 2026-08-24.

    --url-file wird inzwischen gelesen; der Report beschrieb den Zustand davor.

    • src/Kuestenlogik.Bowire.Tool/Configuration/BowireConfiguration.cs:225 ruft ReadUrlFiles(args) auf. Die Implementierung ab Zeile 322 überspringt Leerzeilen und #-Kommentare, unterstützt mehrfaches --url-file, merged mit --url und wirft harte Fehler bei fehlender oder leerer Datei.
    • Die gelesenen Zeilen landen in options.ServerUrls / ServerUrl (Zeilen 226-264).
    • Fehlerpfad im CLI-Host verdrahtet: src/Kuestenlogik.Bowire.Tool/Cli/BrowserUiHost.cs:51.
    • Abgedeckt von 7 Fällen in tests/Kuestenlogik.Bowire.Tests/UrlFileOptionTests.cs.

    Milestone v2.5 gesetzt: die Arbeit landete nach dem v2.4.0-Tag, und ein geschlossenes Issue ohne Milestone fällt aus Roadmap und Release-Notes heraus.

    Ein Restpunkt aus demselben Bereich gehoert nicht hierher: docs/setup/sidecar.md:100 behauptet, die Datei werde bei Aenderung neu eingelesen. Einen FileWatcher gibt es nicht, sie wird einmal beim Start gelesen. Das wird separat behandelt.

  3. moved this from Backlog to Done in Bowireon Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    • Status
      Done

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions