New plugin to read FITS tables. Note, to compile kst on my machine requ... #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 28, 2014 14:59
…quired me to remove the KST_THREAD_LOCAL keywords from kst_atof.h and kst_atof.cpp. This is because my compiler doesn't seem to support "thread local storage", or whatever that is. Secondly, I had to disable the fitsimage plugin in src/datasources/CMakeLists.txt. For some reason, I got errors as if the cfitsio libraries weren't being loaded properly, even though "#include <fitsio.h>" was used in fitsimage.h. Note, my plugin, which also uses fitsio, worked perfectly, so I don't think it was just a problem with linking. In this commit, I did not include the changes I made to kst_atof.h, kst_atof.cpp and the CMakeLists.txt file.
fixed a bug with reading integer columns. Lastly, tweaked listing of available vector names to take into account vectors where naxis == 1.
syntheticpp
force-pushed
the
master
branch
5 times, most recently
from
1fdaf2e to
b35d426
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ired
me to remove the KST_THREAD_LOCAL keywords from kst_atof.h and kst_atof.cpp.
This is because my compiler doesn't seem to support "thread local storage",
or whatever that is.
Secondly, I had to disable the fitsimage plugin in
src/datasources/CMakeLists.txt. For some reason, I got errors as if the cfitsio
libraries weren't being loaded properly, even though "#include <fitsio.h>" was
used in fitsimage.h.
Note, my plugin, which also uses fitsio, worked perfectly, so I don't think
it was just a problem with linking.
In this commit, I did not include the changes I made to kst_atof.h,
kst_atof.cpp and the CMakeLists.txt file.