Skip to content

docs: add ESP32 proxy to getting started guide#67

Merged
KristianP26 merged 1 commit into
mainfrom
dev
Mar 1, 2026
Merged

docs: add ESP32 proxy to getting started guide#67
KristianP26 merged 1 commit into
mainfrom
dev

Conversation

@KristianP26
Copy link
Copy Markdown
Owner

Summary

  • Adds ESP32 BLE Proxy section to the getting started guide with quick setup, config example, and simplified Docker compose
  • Updates Node.js minimum version to v20.19+ in prerequisites
  • Fixes currency (€) and formatting

Adds quick setup instructions, config.yaml example, and simplified
Docker compose reference. Also bumps Node.js version to v20.19+ in
prerequisites and fixes currency/formatting.
Copilot AI review requested due to automatic review settings March 1, 2026 08:38
@KristianP26 KristianP26 merged commit d0fd7d2 into main Mar 1, 2026
5 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Getting Started guide to document using an ESP32 as a remote BLE-to-MQTT “proxy” for deployments where the host has no Bluetooth adapter, and aligns prerequisites/hardware info with recent project changes.

Changes:

  • Adds an “ESP32 BLE Proxy” section with quick setup steps, example config.yaml, and a simplified Docker Compose invocation.
  • Bumps the documented Node.js minimum version to v20.19+.
  • Adjusts some formatting/punctuation and updates hardware pricing to €.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +176 to +182
```yaml
# config.yaml
ble:
handler: mqtt-proxy
mqtt_proxy:
broker: mqtt://your-broker:1883
```
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fenced YAML block is not indented under list item 3, so in CommonMark/VitePress it will render as a separate block and can break/reset the ordered list numbering. Indent the code fence (and its contents) to keep it within the list item.

Suggested change
```yaml
# config.yaml
ble:
handler: mqtt-proxy
mqtt_proxy:
broker: mqtt://your-broker:1883
```
```yaml
# config.yaml
ble:
handler: mqtt-proxy
mqtt_proxy:
broker: mqtt://your-broker:1883

Copilot uses AI. Check for mistakes.
Comment on lines +186 to +189
```bash
# No BlueZ, no D-Bus, no NET_ADMIN needed
docker compose -f docker-compose.mqtt-proxy.yml up -d
```
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fenced bash block is not indented under list item 4, which can cause Markdown renderers to treat it as outside the ordered list (breaking numbering/formatting). Indent the fence and command so it stays part of the list item.

Suggested change
```bash
# No BlueZ, no D-Bus, no NET_ADMIN needed
docker compose -f docker-compose.mqtt-proxy.yml up -d
```
```bash
# No BlueZ, no D-Bus, no NET_ADMIN needed
docker compose -f docker-compose.mqtt-proxy.yml up -d

Copilot uses AI. Check for mistakes.
Comment on lines +191 to +195
Or set the handler via environment variable:

```bash
BLE_HANDLER=mqtt-proxy npm start
```
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BLE_HANDLER=mqtt-proxy env var only takes effect if ble.mqtt_proxy is configured (otherwise it is ignored with a warning). This example reads like setting the env var alone is sufficient; consider clarifying that the broker/topic config still needs to be present in config.yaml (or provided via whatever supported config mechanism).

Copilot uses AI. Check for mistakes.
ble:
handler: mqtt-proxy
mqtt_proxy:
broker: mqtt://your-broker:1883
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example configuration uses broker: mqtt://your-broker:1883, which connects to the MQTT broker without TLS, exposing BLE-derived data and control messages to interception or tampering by any on-path attacker on the network. In environments where the broker is reachable by untrusted clients (e.g., shared WiFi or non-isolated networks), this can lead to disclosure of weight/health data and forged MQTT commands controlling BLE interactions. Consider updating the example to demonstrate a secure mqtts:// endpoint and document TLS/authentication expectations, or clearly constrain plaintext MQTT usage to tightly controlled networks only.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants