Conversation
tteschemacher
requested review from
RiccardoRossi,
andreas-apostolatos,
philbucher and
pooyan-dadvand
oberbichler
left a comment
oberbichler
left a comment
There was a problem hiding this comment.
Good idea for NURBS or any other geometry with a regular mesh. I am just wondering what would be the value returned e.g. by a triangle.
| * @brief Computes a vector index from three tensor indicies. | ||
| * @return index within vector | ||
| */ | ||
| static constexpr inline IndexType GetVectorIndexFromTensorIndices( |
There was a problem hiding this comment.
I think Tensor is not the best term. But one understands what is meant.
There was a problem hiding this comment.
I totally agree. If you have any suggestion I will be open for it!
There was a problem hiding this comment.
In ANurbs I call it single/double/triple index (last one is not in use). But that's not really critical. I think the behaviour on irregular meshes is more important.
There was a problem hiding this comment.
btw: what is the reason to put this function into the geometry base class?
There was a problem hiding this comment.
Actually this comes from the irregular meshes (triangles), either we derive this function there, or the GetPoint functions. If it will be the GetPoint functions I totally agree that we need to extract this in an external file.
| /// returns number of control points in direction u. | ||
| SizeType GetNumberOfPointsU() const override | ||
| { | ||
| return NumberOfControlPointsU(); |
There was a problem hiding this comment.
It would make sense to rename NumberOfControlPointsU/V instead of heaving two functions with the same output.
There was a problem hiding this comment.
I agree. As this interface is already used I would change it as soon as this is agreed and merged.
tteschemacher
left a comment
tteschemacher
left a comment
There was a problem hiding this comment.
Thanks for your comments!
3 participants
Hi all,
I am adding here a possible access to points of geometries with multiple dimensions. Here, the index does not need to be known, only the index per direction. This function would also coincide with the correct access of the shape functions.
Please let me know what you think about it?
Thx