Migrated to Korro 0.2.2#1846
Conversation
AndreiKingsley
changed the title
# Conflicts: # samples/build.gradle.kts
| subprojects { | ||
| this.version = rootProject.version | ||
|
|
||
| tasks.matching { |
There was a problem hiding this comment.
we should not use subprojects {} anymore. Instead, this logic should be in the relevant build-logic convention plugins
There was a problem hiding this comment.
or only in the build files where korro is applied
There was a problem hiding this comment.
I mean, eventually we will probably have a korro convention plugin #1661 where this logic could live
There was a problem hiding this comment.
@Jolanrensen we will use korro only in :samples after migration (#898), so there's no need in korro convention plugin.
Can we just keep it for now?
There was a problem hiding this comment.
Hmm. I see you did write mustRunAfter logic in :core but not in :samples, which looks a bit odd. It's okay to do it without convention plugin, but then the logic should be in :samples, not in the root project
2 participants
Closes #1814.