This repository was archived by the owner on Nov 4, 2025. It is now read-only.
Made UI more like Google apps#59
Merged
Koitharu merged 2 commits intoKotatsuApp:develfrom Sep 5, 2021
ztimms73:ui-patch
Merged
Made UI more like Google apps#59Koitharu merged 2 commits intoKotatsuApp:develfrom ztimms73:ui-patch
Koitharu merged 2 commits intoKotatsuApp:develfrom
ztimms73:ui-patch
Conversation
Koitharu
reviewed
Aug 25, 2021
| left = insets.left, | ||
| right = insets.right | ||
| binding.pager.updatePadding( | ||
| top = -(resources.resolveDp(56) + insets.top) |
Member
Author
There was a problem hiding this comment.
The height of the AppBarLayout. Replaced by measureHeight
| binding.recyclerView.updatePadding( | ||
| bottom = insets.bottom | ||
| ) | ||
| val headerHeight = insets.top + resources.resolveDp(64) |
Member
There was a problem hiding this comment.
Magic number, it will be better to move 64dp into dimens
Member
|
I think it is time for a new release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
style="@style/Widget.AppCompat.ProgressBar.Horizontal"ofLinearProgressIndicatorinfragment_details)AnimatedToolbarinsheet_pages, the Toolbar with text was not full-length on the tablet, it was cropped, which is strangeHowever, there was one question. Do we need to do something with the filter, i.e. move it from DrawerLayout to BottomSheet?
