Rework ModelPatcher for upcoming ComfyUI update #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fyUI ModelPatcher changes/ADE
…ntrol change and removed need to a terribly ugly hack that was required before to get the cond_or_uncond; now can just be gotten from transformer_options
…der for ContextRef
…ontextRef-related code in BankStyle classes
…seCtrl), continued work on DinkLink
…del_optional fields, shifted some of the nodes.py code around to separate files to make deprecation cleaner
…tinMroz's revised js, fixed outdated autosize values
…t instead of control_net_name to leave more room for CN name
… WrapperHook, ReferenceCN now can respect individual conds
…ntrolnet prerun can be ran properly
…fyUI memory management system; parent model patcher has to be tracked properly now
…e passed into get_control with ComfyUI rework
…e future with new memory management system
…ead to fix weird issue with ContextRef + ImageInjection
3 tasks
…way to disable multiplying compression_ratio by vae.downscale_ratio when not needed
…xpected cond_hint size
…optimization when needed, fixed missing transformer_options input into default_control_actions
This was
linked to
issues
Nov 26, 2024
…a useless default keyframe to clone each time it's called
… to ControlNetAdvanced to support ControlNetSD35
…odel definition/creation; allows for code to not be duplicated and any feature that works for AD can be resued/exposed for SparseCtrl
…odelPatcher, just in case it's messing with memory management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies code to use ComfyUI's built-in hooks/wrappers/callbacks system from the PR I submitted, allowing a bunch of hacks to be removed.
Notable changes/features: