Skip to content

use vite paths#9857

Open
jackkav wants to merge 1 commit intoKong:developfrom
jackkav:chore/vite-tsconfig-paths
Open

use vite paths#9857
jackkav wants to merge 1 commit intoKong:developfrom
jackkav:chore/vite-tsconfig-paths

Conversation

@jackkav
Copy link
Copy Markdown
Contributor

@jackkav jackkav commented Apr 23, 2026

remove deprecated baseUrl

Copilot AI review requested due to automatic review settings April 23, 2026 07:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Insomnia build tooling to rely on Vite/tsconfig path mapping and removes baseUrl from several tsconfig files.

Changes:

  • Add vite-tsconfig-paths to the Insomnia Vite config and dev dependencies.
  • Remove compilerOptions.baseUrl from packages/insomnia, packages/insomnia-api, and component docs tsconfig.
  • Update package-lock.json to reflect the new dependency tree.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/insomnia/vite.config.ts Adds vite-tsconfig-paths plugin to resolve TS path aliases in Vite.
packages/insomnia/tsconfig.json Removes baseUrl from compiler options.
packages/insomnia/package.json Adds vite-tsconfig-paths to devDependencies.
packages/insomnia-component-docs/tsconfig.json Removes baseUrl override block for editor-only tsconfig.
packages/insomnia-api/tsconfig.json Removes baseUrl from compiler options.
package-lock.json Adds vite-tsconfig-paths (and includes additional dependency resolution changes).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +56 to +58
viteTsconfigPaths({
root: __dirname,
}),
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vite-tsconfig-paths appears to be redundant here because the config already hard-codes the ~ alias via resolve.alias (same mapping as tsconfig.json's paths). Keeping both sources of truth can lead to drift/confusion; consider removing the manual alias (and using the plugin everywhere that needs it, e.g. Vitest) or dropping the plugin if the alias stays.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants