fix: curl import issue when parse the pair value#9198
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the cURL importer where strings containing multiple equals signs were incorrectly parsed. The fix replaces the split('=') approach with indexOf and slice to properly handle key-value pairs that have equals signs in their values.
- Replaced
split('=')withindexOfandsliceto preserve data after the first equals sign - Updated logic to handle cases where no equals sign is present
- Added comprehensive test cases for various scenarios with multiple equals signs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/insomnia/src/utils/importers/importers/curl.ts | Updated pair parsing logic to use slice instead of split for handling multiple equals signs |
| packages/insomnia/src/utils/importers/importers/curl.test.ts | Added test cases to verify correct parsing of data with multiple equals signs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CurryYangxx
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INS-1502
fixes #9163
Changes
Use slice to replace split to avoid string discard when multiple
=in the data.