Fix: lint invalid ruleset panic #1689
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1689 +/- ##
==========================================
- Coverage 28.24% 28.19% -0.06%
==========================================
Files 67 67
Lines 6949 6949
==========================================
- Hits 1963 1959 -4
- Misses 4845 4848 +3
- Partials 141 142 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mheap
force-pushed
the
fix/lint-invalid-ruleset-panic
branch
from
9000824 to
9b1492b
Compare
Member
|
I need to drop this for a while. The next steps are to upgrade the tests to respect the new default rules for OAS |
harshadixit12
force-pushed
the
fix/lint-invalid-ruleset-panic
branch
from
9b1492b to
2fa46b0
Compare
harshadixit12
force-pushed
the
fix/lint-invalid-ruleset-panic
branch
from
769fb38 to
e205db9
Compare
Contributor
Author
Update on this - the output from linting doesn't seem to be deterministic anymore on v0.17, and there are issues with concurrency due to which tests are failing. Doesn't seem to be a quick fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1673, https://konghq.atlassian.net/browse/FTI-6730
Root cause: The version of vacuum module we used to lint did not append the rule to context if there were errors in validating the rule. This led to panic when we expected rule to be present later. This has been fixed in later releases.
Todo:
Verify that the version bump does not cause breaking changes